Fix for labels for tags and name override each other#99
Open
febbraro wants to merge 6 commits intoaacebedo:developfrom
Open
Fix for labels for tags and name override each other#99febbraro wants to merge 6 commits intoaacebedo:developfrom
febbraro wants to merge 6 commits intoaacebedo:developfrom
Conversation
…ing it, also moved region to the correct place as a subdomain of image
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on the conversation in #88 here is a (kong overdue) PR that addresses a few issues with domain name creation.
Names are now formed based on the following format:
[tag].[name].[region].[image].[environment].[domain]Just like the current implementation this will only take the first tag if there is a csv value for tags. A future PR can add support for creating additional aliases based on multiple tag values.